Update pubsub emu to 0.8.29#10092
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the currency of the project's dependencies by upgrading the Google Cloud Pub/Sub emulator to its latest stable version. This ensures that development and testing environments utilize the most recent features and bug fixes available for the emulator, contributing to a more robust and up-to-date development workflow. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request updates the Pub/Sub emulator to version 0.8.29. This change involves updating the version number, expected file size, checksums, and download paths within src/emulator/downloadableEmulatorInfo.json, and also documenting the version bump in CHANGELOG.md.
aalej
left a comment
aalej
left a comment
There was a problem hiding this comment.
Looks like the memory leak issue is still present in this version
$ firebase emulators:start --project pubsub-debug
i emulators: Starting emulators: pubsub
i pubsub: downloading pubsub-emulator-0.8.29.zip...
Progress: ======================================================================================================================================================> (100% of 53MB)
i pubsub: Removing outdated emulator files: pubsub-emulator-0.8.17
i pubsub: Removing outdated emulator files: pubsub-emulator-0.8.17.zip
i pubsub: Pub/Sub Emulator logging to pubsub-debug.log
⚠ emulators: The Emulator UI is not starting because none of the running emulators have a UI component.
┌─────────────────────────────────────────────────────────────┐
│ ✔ All emulators ready! It is now safe to connect your app. │
└─────────────────────────────────────────────────────────────┘
┌──────────┬────────────────┐
│ Emulator │ Host:Port │
├──────────┼────────────────┤
│ Pub/Sub │ 127.0.0.1:8515 │
└──────────┴────────────────┘
Emulator Hub host: 127.0.0.1 port: 4400
Other reserved ports: 4500
Issues? Report them at https://github.com/firebase/firebase-tools/issues and attach the *-debug.log files.
Compared with 0.8.17
$ firebase emulators:start --project pubsub-debug
i emulators: Starting emulators: pubsub
⚠ pubsub: Env variable override detected. Using custom pubsub emulator version 0.8.17.
i pubsub: downloading pubsub-emulator-0.8.17.zip...
Progress: ======================================================================================================================================================> (100% of 66MB)
i pubsub: Removing outdated emulator files: pubsub-emulator-0.8.29
i pubsub: Removing outdated emulator files: pubsub-emulator-0.8.29.zip
i pubsub: Pub/Sub Emulator logging to pubsub-debug.log
⚠ emulators: The Emulator UI is not starting because none of the running emulators have a UI component.
┌─────────────────────────────────────────────────────────────┐
│ ✔ All emulators ready! It is now safe to connect your app. │
└─────────────────────────────────────────────────────────────┘
┌──────────┬────────────────┐
│ Emulator │ Host:Port │
├──────────┼────────────────┤
│ Pub/Sub │ 127.0.0.1:8515 │
└──────────┴────────────────┘
Emulator Hub host: 127.0.0.1 port: 4400
Other reserved ports: 4500
Issues? Report them at https://github.com/firebase/firebase-tools/issues and attach the *-debug.log files.
using dev's mcve - https://github.com/atillay/pubsub-emulator-issue
4 participants
Description
Update pubusb emulator to 0.8.29
So proud of Gemini here - I told AGY to check for updates following the skill, and it one shotted this correctly.